Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add constAsEnum flag to convert constant values to single value enum #571

Merged
merged 2 commits into from
Sep 7, 2023

Conversation

gassiss
Copy link
Contributor

@gassiss gassiss commented Aug 30, 2023

Closes #570

Please:

  • Make your pull request atomic, fixing one issue at a time unless there are many relevant issues that cannot be decoupled.
  • Provide a test case & update the documentation in the Readme.md

@domoritz
Copy link
Collaborator

What do you think about #287? Should we have a flag for openapi compatibility instead?

@gassiss
Copy link
Contributor Author

gassiss commented Sep 5, 2023

What do you think about #287? Should we have a flag for openapi compatibility instead?

In our use case, we never got any errors related to nullable strings, and we do have them. So looks like the ask is a no-op. Would you prefer if I changed the flag to openApiCompatible or something? (please suggest a better name, lol 😅 )

@domoritz
Copy link
Collaborator

domoritz commented Sep 6, 2023

Nah, let's leave the flag as is then. Please fix the linting error.

@domoritz domoritz merged commit a9bb215 into YousefED:master Sep 7, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add optional flag to convert const to single value enums
2 participants