Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #426 #569

Merged
merged 2 commits into from
Sep 1, 2023
Merged

fix #426 #569

merged 2 commits into from
Sep 1, 2023

Conversation

chatcan
Copy link
Contributor

@chatcan chatcan commented Aug 28, 2023

Please:

  • Make your pull request atomic, fixing one issue at a time unless there are many relevant issues that cannot be decoupled.
  • Provide a test case & update the documentation in the Readme.md

@domoritz domoritz changed the title fix https://github.com/YousefED/typescript-json-schema/issues/426 fix #426 Aug 30, 2023
@@ -724,6 +724,44 @@ export class JsonSchemaGenerator {
if (!!Array.from((<any>propertyType).members)?.find((member: [string]) => member[0] !== "__index")) {
this.getClassDefinition(propertyType, definition);
}
} else if (propertyType.flags & ts.TypeFlags.TemplateLiteral) {
definition.type = "string";
// @ts-ignore
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are you ignoring here?

@domoritz domoritz merged commit 3268f3b into YousefED:master Sep 1, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants