Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turn on "noExtraProps" flag in auto test #563

Merged

Conversation

netanel-mce
Copy link
Contributor

@netanel-mce netanel-mce commented Aug 9, 2023

This pr is intended to improve the quality of autotests to include noExtraProps by default

@@ -2,5 +2,5 @@ interface ChildFoo {
}

interface Foo {
readonly childFoos: Foo & ChildFoo;
readonly childFoos: Foo | ChildFoo;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this type with &, is endless type, and no data to be valid for this type.

image

@netanel-mce netanel-mce changed the title Recursive type with no extra props flag turn on "noExtraProps" flag in auto test Aug 20, 2023
@netanel-mce netanel-mce marked this pull request as ready for review August 20, 2023 14:46
@domoritz domoritz merged commit 3662786 into YousefED:master Aug 20, 2023
1 check passed
@netanel-mce netanel-mce deleted the recursive-type-with-no-extra-props-flag branch August 22, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants