Feature/capitalize title #561
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domoritz
requested changes
Jul 24, 2023
| let properties = schema!.properties; | ||
| assert.notEqual(schema!.properties, undefined) | ||
| properties = properties!; | ||
| for (const property of Object.entries(properties)) { |
There was a problem hiding this comment.
Instead of testing with some logic, please just create a new test case or update an existing test case with a fully specified example.
There was a problem hiding this comment.
I do not understand what I should do
There was a problem hiding this comment.
Unit tests should have as little logic as possible to make them easier to debug and find issues. Your test uses the same library we use to generate the title so if something ever changes, we don’t notice it in the test. Ideally tests don’t have loops or call libraries.
|
Closing since there is some work to be done here to wrap this up. There is a workaround in #559 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please:
Readme.mdFixes #559