Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change directories before pip installation on M1 mac install #188

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

astrovsky01
Copy link

I had the same issue as #180, and found that the binary was being called from the wrong location in the filesystem. Just added a directory change to be able to find the files

@YoshitakaMo
Copy link
Owner

Thank you for your PR. Meanwhile, I've tried to find the reason why I can't install localcolabfold on my M1 mac in these days. Thus I was unable to verify the Issue or PR. Today, I've finally figured out the cause, maybe ulimit setting.
I've just updated the installer for M1 mac to use mambaforge without Homebrew cask's one. Could you try the installation again using this?

@astrovsky01
Copy link
Author

I'll test that, sure. I will also say that while trying to install locally, the conda environment would not start from inside the bash script, which caused a lot of havoc with other conda installations I had on my machine, and led to me having to uninstall all conda versions before being able to install properly. The conda activate command repeatedly errored saying activate was not a valid option. I cannot say if fixing that would fix the other issue I had that was also resolved with the reinstallation of conda where I could not download the tensorflow-deps package at all.

@astrovsky01
Copy link
Author

Thank you for your PR. Meanwhile, I've tried to find the reason why I can't install localcolabfold on my M1 mac in these days. Thus I was unable to verify the Issue or PR. Today, I've finally figured out the cause, maybe ulimit setting. I've just updated the installer for M1 mac to use mambaforge without Homebrew cask's one. Could you try the installation again using this?

I got an error on line 38 that there is no such file as /localcolabfold/conda/etc/profile.d/conda.sh

@YoshitakaMo
Copy link
Owner

I got an error on line 38 that there is no such file as /localcolabfold/conda/etc/profile.d/conda.sh

This message is curious. It means that variables CURRENTPATH and COLABFOLDDIR were not correctly set in the bash script. Could you try to add echo "CURRENTPATH = ${CURRENTPATH}" and echo "COLABFOLDDIR = ${COLABFOLDDIR}" to the installer script?

Expected values:

CURRENTPATH=`pwd`
COLABFOLDDIR="${CURRENTPATH}/localcolabfold"
echo "CURRENTPATH = ${CURRENTPATH}"
# CURRENTPATH = /Users/moriwaki/Desktop
echo "COLABFOLDDIR = ${COLABFOLDDIR}"
# COLABFOLDDIR = /Users/moriwaki/Desktop/localcolabfold
# exit here
exit 0

You suggested adding cd localcolabfold before colabfold-conda/bin/python3.10 -m pip install tensorflow-macos, but this failed in my environment (though no problems with the installation).

Downloading and Extracting Packages
                                                                                                                                                                                                                                              
Preparing transaction: done                                                                                                                                                                                                                   
Verifying transaction: done                                                                                                                                                                                                                   
Executing transaction: done                                                                                                                                                                                                                   
install_colabbatch_M1mac.sh: line 50: cd: localcolabfold: No such file or directory                                                                                                                                                             
Collecting tensorflow-macos                                                                                                                                                                                                                   
  Using cached tensorflow_macos-2.14.0-cp310-cp310-macosx_12_0_arm64.whl.metadata (3.9 kB)                                                                                                                                                    
Collecting absl-py>=1.0.0 (from tensorflow-macos)                                                                                                                                                                                             
  Using cached absl_py-2.0.0-py3-none-any.whl.metadata (2.3 kB)
...
...

@astrovsky01
Copy link
Author

I got the same error on the second attempt at the install with the echos built in, but when I added an echo 'test' to check where things were reaching and erroring with a bit more granularity, it ran ok.
In response to your testing of mine, this new installer added a cd that didn't exist in the version last week on line 34 which does the same thing as my PR,

@astrovsky01
Copy link
Author

@YoshitakaMo the update script also assumes the incorrect location of the colabfold-conda directory, as that is generated in a subdirectory, and also does not currently retrieve the current directory. Would you like me to submit a PR for that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants