Convert bool values from a .ini file

[hiromu]

When I use a .ini file for configuration, some variables are passed to bravado-core in the form of str and always treated as True.
Since all variables except formats are boolean, they should be converted using asbool(): https://bravado-core.readthedocs.io/en/stable/config.html

The same thing happens for enable_api_doc_views in __init__.py, and thus I fixed.

[coveralls]

Coverage decreased (-99.6%) to 0.0% when pulling cbe5f57 on hiromu:convert-bool-values-in-ini-file into 2c8d37f on striglia:master.

[sjaensch]

Thank you for your contribution @hiromu! As mentioned we need to make sure this is forwards-compatible. Also, how were you specifying config values that you ran into this issue? bravado-core itself doesn't use asbool.

[sjaensch]

This is dangerous, as any new bravado-core config key which doesn't have a boolean value would break this. We should instead list the bravado-core keys we know of and the function we should use for each key to get the value. Ideally we'd provide an API to do this within bravado-core.

[sjaensch]

This doesn't handle formats.

[hiromu]

I understand your concerns on the forward compatibility.

Are you considering to implement an API within bravado-core? Otherwise, I'll update this pull request so as to use a hard-coded allowlist to determine whether to apply asbool.

how were you specifying config values that you ran into this issue?

In my implementation, I'm specifying bravado_core.internally_dereference_refs = false in environment.ini and just calling config = Configurator(settings=settings); config.include('pyramid_swagger') in main(global_config, **settings) of Pyramid.