Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Travis-ci to Github actions #81

Merged
merged 3 commits into from
Aug 17, 2023
Merged

Migrate Travis-ci to Github actions #81

merged 3 commits into from
Aug 17, 2023

Conversation

Chandra158
Copy link
Contributor

@Chandra158 Chandra158 commented Aug 17, 2023 •
edited
Loading

Overview

  • Travis-ci is no longer free for build; migrated to use Github Actions
    • fuzz-lightyear-build
  • Integration test fails for mac/windows due to changes multiprocessing in python3.8
    • replaced with multiprocess.Process
  • test_successful_sequence is flaky in latest patch version of python3.8 (3.8.17 available for Github Actions)
    • fixed a range of python versions to be used in build pipeline

Verification

  • make test passes for all platforms

danielpops
danielpops approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@danielpops danielpops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! I'm surprised there's no target to publish to pypi. If you want to set that up, an open source deputy can help you out with that :)

@Chandra158
Copy link
Contributor Author

Chandra158 commented Aug 17, 2023 •
edited
Loading

@danielpops yes please; I'd want to do that next.

@Chandra158 Chandra158 merged commit 4c1ccbe into master Aug 17, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorenzodb1 lorenzodb1 lorenzodb1 approved these changes

@nasimmaleki nasimmaleki nasimmaleki approved these changes

@danielpops danielpops danielpops approved these changes

@calvinli calvinli Awaiting requested review from calvinli

@jpdakran jpdakran Awaiting requested review from jpdakran

@nikhilvats1 nikhilvats1 Awaiting requested review from nikhilvats1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Chandra158 @danielpops @nasimmaleki @lorenzodb1