Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken filtering for images used by containers #43

Merged
merged 1 commit into from
May 17, 2017

Conversation

chekunkov
Copy link
Contributor

@chekunkov chekunkov commented Apr 21, 2017

Fixes errors like this:

Error calling remove_image image=xxx:latest 409 Client Error: Conflict ("conflict: unable to remove repository reference "xxx:latest" (must force) - container 91ab644a7b31 is using its referenced image 7caea3c78386")

The error is caused by mismatch between entry in image_tags_in_use and tag produced inside filter_images_in_use

For in my local tests image used by container without tags and with id 'sha256:ff5f2ec93a207bdf948f986bc94e938977979befedd53121a32e8d74fc58fb8e' produced set set(['sha256:ff5f2:latest']) that didn't match with entry from the image_tags_in_use which was full image id.

Also see #14

Error calling remove_image image=xxx:latest 409 Client Error: Conflict ("conflict: unable to remove repository reference "xxx:latest" (must force) - container 91ab644a7b31 is using its referenced image 7caea3c78386")
@chekunkov
Copy link
Contributor Author

Tests fail because of pypa/setuptools#951, probably should be fixed in another PR

@dnephin
Copy link
Contributor

dnephin commented Apr 26, 2017

Thanks, I think this is a good change, but we need to get CI fixed before we can merge.

Are you familiar with the issue? Is the fix just to require a specific version of setuptools in requirements.txt ?

@chekunkov
Copy link
Contributor Author

Hi @dnephin Yes, pinning setuptools to a specific version should fix the issue, e.g. that's what we've done in scrapinghub/scrapinghub-stack-hworker#17

@dnephin
Copy link
Contributor

dnephin commented May 17, 2017

I clicked rebuild on travis, it seems things are fixed.

@dnephin dnephin added the bug label May 17, 2017
Copy link
Contributor

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnephin
Copy link
Contributor

dnephin commented May 17, 2017

cc @danielhoherd @solarkennedy

@solarkennedy
Copy link
Contributor

Thanks!

@solarkennedy solarkennedy merged commit 4fb6946 into Yelp:master May 17, 2017
@chekunkov chekunkov deleted the fix-image-in-use branch May 18, 2017 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants