Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API for python scripts Issue #713 #836

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

issabayevmk
Copy link

@issabayevmk issabayevmk commented May 17, 2024

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added
  • Docs have been added / updated
  • All CI checks are green
  • What kind of change does this PR introduce?

New API to import detect-secrets into other python scripts

  • What is the current behavior?

Currently detect-secrets does not provide easy options to import and scan strings/files/repos

  • What is the new behavior (if this is a feature change)?
    API for usage of detect-secrets from other python scripts. Supports:
  • Get list of supported plugins
  • Scan a string with all plugins or specified plugins
  • Scan a file with all plugins or specified plugins
  • Scan a git repository with all plugins or specified plugins. There is an options to specify to scan only git tracked files or all files
  • Does this PR introduce a breaking change?
  • NO
  • Other information:

@lorenzodb1
Copy link
Member

@issabayevmk I'll find some time to review this properly. In the meantime, could you please take a look at the tests?

@issabayevmk issabayevmk marked this pull request as draft June 6, 2024 09:03
@issabayevmk
Copy link
Author

Hi @lorenzodb1. Thanks for your reply, I will review tests.

@issabayevmk issabayevmk marked this pull request as ready for review June 7, 2024 11:47
@lorenzodb1
Copy link
Member

Hi @issabayevmk, looks like you're missing some coverage now!

@issabayevmk
Copy link
Author

issabayevmk commented Jun 14, 2024

@lorenzodb1 , I have improved coverage, now it is 98% for api.py.

@lorenzodb1
Copy link
Member

@issabayevmk it looks like pre-commit checks are still failing

@issabayevmk
Copy link
Author

@lorenzodb1 windows tests now fixed and all tests are green on my fork

@issabayevmk issabayevmk changed the title Issabayevmk api for python scripts API for python scripts Jun 28, 2024
@issabayevmk issabayevmk changed the title API for python scripts API for python scripts #713 Jun 28, 2024
@issabayevmk issabayevmk changed the title API for python scripts #713 API for python scripts Issue #713 Jun 28, 2024
@issabayevmk
Copy link
Author

Hi @lorenzodb1! Could you please review my PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants