Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve b261af9fbd8bfcc3f412ab48f283c1970e5841c0 (#568) #634

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve b261af9fbd8bfcc3f412ab48f283c1970e5841c0 (#568) #634

wants to merge 1 commit into from

Conversation

clonejo
Copy link

@clonejo clonejo commented Nov 6, 2022

  • move try-except up the stack, so we actually have a line number and not only the column
  • also catch IndexError (eg. if the file has fewer lines than secret.line_number)

@clonejo
Improve b261af9 (Yelp#568)
6459b4d 
- move try-except up the stack, so we actually have a line number and
  not only the column
- also catch IndexError (eg. if the file has fewer lines than
  secret.line_number)
@clonejo
Copy link
Author

clonejo commented Nov 6, 2022

i apologize for the formatting, i have my editor configured to run black on save.

@clonejo clonejo mentioned this pull request Nov 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@clonejo