New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes #471

Open

dstoeckel wants to merge 3 commits into Yelp:master from dstoeckel:minor_fixes

+3 −2

dstoeckel commented Oct 17, 2017

This is a collection of minor fixes that resolve:

A compilation error
Dramatically reduce the amount of warnings generated by GCC 7.x

dstoeckel added 3 commits

October 10, 2017 10:24


          Fix compile: add missing <numeric> include

a4c54f4

std::iota is defined in <numeric>, but this header was not included.


          Fix warnings in gpp_optimization.hpp

0cc6b98

Add noexcept to a closure that is known to never throw.


          Fix warnings in gpp_test_utils.cpp

49f5fa9

The print macro used %lld format strings for int64_t parameters.
Use %ld instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet