Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix Argument CamelCap Handling + Remote Run Input #355

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

MFA-X-AI
Copy link
Member

Description

This PR fixes:

  • duplicate form inputs spawning when toggling remote run dropdown
  • camel caps in arguments not handled properly

Pull Request Type

  • Xircuits Core (Jupyterlab Related changes)
  • Xircuits Canvas (Custom RD Related changes)
  • Xircuits Component Library
  • Xircuits Project Template
  • Testing Automation
  • Documentation
  • Others (Please Specify)

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tests

  • Drag in an argument component. Save, compile, run it to see the number of input forms. Toggle the run type. Run it again. Ensure that the number of form inputs are the sam
  • Drag in an argument component. Use camelcaps. Compile and run. Verify that the output contains the input provided.

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

Notes

This PR is a WIP of a bigger update of updating the remote run feature.

Copy link

Binder 👈 Launch a binder notebook on branch XpressAI/xircuits/fahreza/remote-update

@MFA-X-AI MFA-X-AI merged commit 67dc602 into master Sep 6, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant