Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay search based re-render until user has stopped typing #344

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

treo
Copy link
Contributor

@treo treo commented Jul 19, 2024

Description

It can take quite a while to render all preview nodes when the user types in a search query, in particular on the first few letters when there are still potentially a lot of results.

This PR introduces a short delay (150ms) before the search is actually executed.

Pull Request Type

  • Xircuits Core (Jupyterlab Related changes)
  • Xircuits Canvas (Custom RD Related changes)
  • Xircuits Component Library
  • Xircuits Project Template
  • Testing Automation
  • Documentation
  • Others (Please Specify)

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

Copy link

Binder 👈 Launch a binder notebook on branch XpressAI/xircuits/paul/quicker-search

@MFA-X-AI MFA-X-AI merged commit 3f27aeb into master Jul 19, 2024
8 checks passed
@MFA-X-AI MFA-X-AI deleted the paul/quicker-search branch July 19, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants