Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix Library Components + Argument Any Type Checking #338

Merged
merged 2 commits into from
Jul 10, 2024
Merged

🐛 Fix Library Components + Argument Any Type Checking #338

merged 2 commits into from
Jul 10, 2024

Conversation

MFA-X-AI
Copy link
Member

@MFA-X-AI MFA-X-AI commented Jul 8, 2024

Description

This PR allows Argument Any to be connected to any ports, as it should. It also fixes the port type checks for normal library components.

Pull Request Type

  • Xircuits Core (Jupyterlab Related changes)
  • Xircuits Canvas (Custom RD Related changes)
  • Xircuits Component Library
  • Xircuits Project Template
  • Testing Automation
  • Documentation
  • Others (Please Specify)

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tests

  1. Verify that you can connect Argument Any to any port types.
  2. Verify that type checks between library components work again. The timer component has a unique port type for testing.

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024

Binder 👈 Launch a binder notebook on branch XpressAI/xircuits/fahreza/typecheck-fix

@MFA-X-AI MFA-X-AI merged commit a064f51 into master Jul 10, 2024
9 checks passed
@MFA-X-AI MFA-X-AI deleted the fahreza/typecheck-fix branch July 10, 2024 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MFA-X-AI