Replace JNA usage in ArrowTransferDefinitions with JavaCPP #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kCyclone into transferdefinitions
…path to the VectorEngine ForkOptions
wgip
reviewed
Feb 16, 2022
wgip
reviewed
Feb 16, 2022
Can't exclude any because they don't have defaults
saudet
reviewed
Feb 17, 2022
src/main/resources/com/nec/cyclone/cpp/cyclone/transfer-definitions.hpp
Outdated
Show resolved
Hide resolved
|
Shows merge conflicts at the moment
|
|
Working on the merge now. |
|
FYI there remain a few usages of JNA which need to be replaced, in |
|
Unit test JVM looks good
|
|
CMake scope
If possible, might be appropriate load the lib programmatically rather than via SBT, then it should be more consistent across different scopes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs to be reconciled with the addition of NullableScalarVec before merging (
transfer-definitions.cppand parts oftransfer-definitions.hppcan be removed when this is done).Was passing all tests before the latest merge (with additions to NullableScalarVec) , currently compiles but fails tests.