Fix UserWarning: Defining your __torch_function__ as a plain method is deprecated and will be an error in future, please define it as a classmethod.
#565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
V0XNIHILI
changed the title
__torch_function__ as a plain method is deprecated and will be an error in future, please define it as a classmethod.
…s deprecated and will be an error in future, please define it as a classmethod.
V0XNIHILI
changed the title
__torch_function__ as a plain method is deprecated and will be an error in future, please define it as a classmethod.__torch_function__ as a plain method is deprecated and will be an error in future, please define it as a classmethod.
V0XNIHILI
force-pushed
the
fix/class-method-issue
branch
from
e96f6df
to
fc9ccc8
Compare
|
@Giuseppe5 is this okay? |
Giuseppe5
requested changes
May 5, 2023
| @@ -79,6 +79,7 @@ def training(self): | |||
| else: | |||
| return None | |||
|
|
|||
| @classmethod | |||
| def __torch_function__(self, func, types, args=(), kwargs=None): | |||
There was a problem hiding this comment.
Could you rename self to cls?
|
Apart from the change of I would wait for your commit and @volcacius comments, and eventually merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://github.com/pytorch/pytorch/blob/08766b23de8ed50a8f52973df78114426500cb65/torch/overrides.py#L1547.
I get this error with the latest version of Brevitas (installed via
pipone week ago) with PyTorch 1.13