This repository has been archived by the owner on May 10, 2022. It is now read-only.
feat: support prometheus #110
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foreverneverer
force-pushed
the
prometheus-support
branch
from
6b85907
to
266b9c8
Compare
foreverneverer
force-pushed
the
prometheus-support
branch
from
266b9c8
to
a0abfd6
Compare
levy5307
reviewed
Jun 10, 2020
| @@ -45,7 +46,8 @@ | |||
| private final Duration operationTimeout; | |||
| private final int asyncWorkers; | |||
| private final boolean enablePerfCounter; | |||
| private final String falconPerfCounterTags; | |||
| private final String perfCounterType; | |||
There was a problem hiding this comment.
what about define a enum to represent the type of perf counter?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr support the prometheus:
