Fix NullPointerException when first joining world #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using this mod with the FTB Revelation modpack (1.12.2), at some point joining the server with ItemESP enabled will start always crashing the game due to a NPE in
mc.getRenderManager().options. The only vanilla fix is to start a new single-player world, disable ItemESP, and log back in to the server. Re-enabling ItemESP after the inital load seems to work just fine. I assume that the ItemESP is called earlier than it should be, before the render manager options are loaded. I don't know if this PR is a proper fix, but it works great for me.