Better define main CRUD ops' return types #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for my late reply here. Good to decide on the return types. Everything OK for adding the separate PK field for the createObject operation. However, I'd like the |
Based on what we discussed this a while back on slack: https://worldbrain.slack.com/archives/CBLN20LCU/p1545279785004100 I think it's probably better to decide on these return types early on. Not sure exactly about the choices; what do you think?
poltak
force-pushed
the
feature/return-types
branch
from
3969e77 to
cf0847c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on what we discussed this a while back on slack:
https://worldbrain.slack.com/archives/CBLN20LCU/p1545279785004100
I think it's probably better to decide on these return types early on. Not sure exactly about the choices; what do you think?