Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text styling for more readable annotations #9

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

cdharris
Copy link
Contributor

Here's a little suggestion to make the external content more readable by increasing the font size, line height and padding.

I've also made it a Serif font to distinguish it from application content, feels to me a more 'readerly' look. We might want to choose a nice specific Serif font pairing rather than use a generic one, but there's lots more little tweaks yet to come I feel to make the reading experience a bit better (spacing and sizes), here's a little start since I wasn't happy with the default look when sharing.

Here's the look before:
Screenshot from 2021-01-16 17-04-36

And after:
Screenshot from 2021-01-16 16-50-37

Looks good? @blackforestboi @ShishKabab

@ShishKabab
Copy link
Member

I'm not sure about the switch to a serif font (sans serif can be easier to read on a screen), but I like the removal of the spacing. Then again, when it comes to fonts, I'm not a designer.

What it does highlight though, is that lack of contrast between dark green and black/grey. I think this'd be good to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants