Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FED-1850 Add Dart 2.19 to GHA matrix #379

Merged
merged 1 commit into from
Nov 2, 2023
Merged

FED-1850 Add Dart 2.19 to GHA matrix #379

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/dart_ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
fail-fast: false
matrix:
# Can't run on `stable` (Dart 3) until we're fully null-safe.
sdk: [2.18.7]
sdk: [2.18.7, 2.19.6]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to keep 2.18.7?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mm good catch. I don't think there is.

Though, we do currently format under 2.18.7, so we'd have to update that to run on 2.19. To avoid potential merge conflicts with the v7_wip branch, I'd vote to wait to remove it and switch formatting over until after that's merged.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

steps:
- uses: actions/checkout@v2
- uses: dart-lang/setup-dart@v1
Expand Down
Loading