Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 18.2.0 #365

Draft
wants to merge 21 commits into
base: master
Choose a base branch
from
Draft

React 18.2.0 #365

wants to merge 21 commits into from

Conversation

greglittlefield-wf
Copy link
Collaborator

@greglittlefield-wf greglittlefield-wf commented Aug 10, 2023

Based on #339

@aviary3-wk
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@regenvanwalbeek-wf
Copy link

regenvanwalbeek-wf commented Feb 12, 2024

@greglittlefield-wf We started getting react.js and react_dom.js must be loaded. errors because https://cdn-dev.wdesk.org/react-dart/5167194/react_with_react_dom_prod.js no longer exists -- it looks like we must have a 3 month expiry on cdn-dev assets?

I resolved the conflicts and pushed up a change. The tests fail but it successfully generated an asset. Hopefully this will fix our issue 🤞

edit This worked for us

@greglittlefield-wf
Copy link
Collaborator Author

@regenvanwalbeek-wf Sorry about that! 😬

Hmm to help prevent this issue from happening again, would it be possible to load from a local packages/react/... path rather than the dev CDN?

@regenvanwalbeek-wf
Copy link

That's how I was leaning as well - Once I have some free time I will give that a shot (hopefully by tomorrow)

@greglittlefield-wf
Copy link
Collaborator Author

@regenvanwalbeek-wf Sounds good, let me know if we can help with anything!

@regenvanwalbeek-wf
Copy link

(Forgot to mention, we ended up loading from local and it worked fine https://github.com/Workiva/esg_ui/pull/2765)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants