Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fixed Button Style Merge Issue #2951

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

josh-bagwell
Copy link
Contributor

@josh-bagwell josh-bagwell commented Oct 3, 2024

Summary

Fixes: #2946

Updates Button variants to fix merge style issue.

Release Category

Components

Release Note

Updates Button variants to fix merge style issue.


Where Should the Reviewer Start?

/modules/react/button/lib/PrimaryButton.tsx
/modules/react/button/lib/SecondaryButton.tsx
/modules/react/button/lib/TertiaryButton.tsx

@josh-bagwell josh-bagwell added bug Something isn't working ready for review Code is ready for review 11.x and removed bug Something isn't working ready for review Code is ready for review labels Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explicitly pass modifiers to stencils that extend stencil, specifically for our Buttons
1 participant