-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Refreshing GlobalHeader Storybook Example #2891
base: master
Are you sure you want to change the base?
docs: Refreshing GlobalHeader Storybook Example #2891
Conversation
…ader-example-polish
Note crashes after clicking inside.
I also move the Combobox into it's own component. I'd like to do the same for a NotificationLiveBadge.
Removed unused imports and parameters.
{filteredTasks.length === 0 ? ( | ||
<StyledMenuItem as="span">No Results Found</StyledMenuItem> | ||
) : ( | ||
filteredTasks.map(i => ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although mapping works, we should probably use a render function like in the auto complete example:
{model.state.items.length > 0 && (
<Combobox.Menu.List cs={styleOverrides.comboboxMenuList}>
{item => <Combobox.Menu.Item>{item}</Combobox.Menu.Item>}
</Combobox.Menu.List>
)}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll need some help with using this model!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets clean up some of the styles and code examples. Content wise it's great! Thank you as always for working through making our documentation better
Summary
Fixes: none
The Storybook example
GlobalHeader
had some opportunities for improved accessibility.Tooltip
to icon buttonsSearchField
withCombobox
AriaLiveRegion
to demonstrate screen reader supportedCountBadge
Release Category
Documentation, Examples
Release Note
Optional release note message. Changelog and release summaries will contain a pull request title. This section will add additional notes under that title. This section is not a summary, but something extra to point out in release notes. An example might be calling out breaking changes in a labs component or minor visual changes that need visual regression updates. Remove this section if no additional release notes are required.
Checklist
ready for review
has been added to PRFor the Reviewer
Where Should the Reviewer Start?
Areas for Feedback? (optional)
Testing Manually
Screenshots or GIFs (if applicable)
Thank You Gif (optional)