-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add horizontal start and end label position for form field #2881
Merged
alanbsmith
merged 36 commits into
Workday:prerelease/major
from
mannycarrera4:mc-label-positioning
Sep 12, 2024
Merged
feat: Add horizontal start and end label position for form field #2881
alanbsmith
merged 36 commits into
Workday:prerelease/major
from
mannycarrera4:mc-label-positioning
Sep 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mannycarrera4
changed the title
Mc label positioning
feat: Add horizontal start and end label position for form field
Aug 21, 2024
josh-bagwell
reviewed
Sep 9, 2024
josh-bagwell
reviewed
Sep 9, 2024
josh-bagwell
reviewed
Sep 9, 2024
josh-bagwell
reviewed
Sep 9, 2024
Co-authored-by: Josh <[email protected]>
Left some small nits |
Co-authored-by: Josh <[email protected]>
Co-authored-by: Josh <[email protected]>
Co-authored-by: Josh <[email protected]>
Co-authored-by: Josh <[email protected]>
josh-bagwell
approved these changes
Sep 11, 2024
mannycarrera4
commented
Sep 11, 2024
mannycarrera4
added
automerge
and removed
ready for review
Code is ready for review
labels
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #2809
Release Category
Components
Release Note
The orientation prop on the FormField component will be updated to accept the following values:
vertical
,horizontalStart
, andhorizontalEnd
.horizontal
will still be accepted as a value in v12, but it will be deprecated and slated for removal in a future major release. These changes are intended to provide more flexibility with label alignments on FormField elements.Instances where the orientation prop of the FormField component is set to
horizontal
will automatically default tohorizontalStart
via a codemod. A console warning message will also appear with a message to change the prop value to either horizontalStart or horizontalEnd.Checklist
ready for review
has been added to PRFor the Reviewer
Where Should the Reviewer Start?
Areas for Feedback? (optional)
Testing Manually
Screenshots or GIFs (if applicable)
Thank You Gif (optional)