Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Ditch a few console logs from useActionBarModel that can clutter up test logs #2295

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

ahayes91
Copy link
Contributor

Summary

I noticed some console logs when I was running a unit test with some components that relied on CK internally that I figured I could go ahead and declutter:

Screenshot 2023-07-19 at 17 20 44

Feel free to close this if you want to keep them around!

Release Category

Components


Checklist

  • MDX documentation adheres to Canvas Kit's standard MDX template - N/A
  • Label ready for review has been added to PR

For the Reviewer

  • PR title is short and descriptive
  • PR summary describes the change (Fixes/Resolves linked correctly)
  • PR Release Notes describes additional information useful to call out in a release message or removed if not applicable
  • Breaking Changes provides useful information to upgrade to this code or removed if not applicable

Where Should the Reviewer Start?

useActionBarModel.tsx 😏

Testing Manually

It's probably more effort to set up a fresh repro repo than it is to fix the change 😁 Probably any test running a component with ActionBar would show these guys.

Screenshots or GIFs (if applicable)

⬆️

Thank You Gif (optional)

Ken from the Barbie movie putting sunglasses over his sunglasses

@cypress
Copy link

cypress bot commented Jul 19, 2023

1 flaky tests on run #5976 ↗︎

0 918 2 0 Flakiness 1

Details:

Merge aa7fdd9 into e05ca04...
Project: canvas-kit Commit: 8a7588e309 ℹ️
Status: Passed Duration: 07:56 💡
Started: Jul 19, 2023 4:33 PM Ended: Jul 19, 2023 4:41 PM
Flakiness  cypress/integration/Autocomplete.spec.ts • 1 flaky test

View Output Video

Test Artifacts
... > when a value is entered > when down arrow key is pressed > when the user presses the enter key > when the use hits the "2" key > should change the filtered results Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Contributor

@RayRedGoose RayRedGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching this 🙇‍♀️

@alanbsmith alanbsmith enabled auto-merge (squash) July 19, 2023 17:37
@alanbsmith alanbsmith merged commit 53de16a into Workday:master Jul 19, 2023
16 checks passed
@vibdev
Copy link
Contributor

vibdev commented Jul 19, 2023

I was wondering where I sat down my consoles. Thanks for the fix

@ahayes91 ahayes91 deleted the stray-console-logs branch July 20, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants