Skip to content

Commit

Permalink
fix: Add ids to docs headings
Browse files Browse the repository at this point in the history
  • Loading branch information
manuel.carrera committed Jul 11, 2023
1 parent e6c02a9 commit 8e810ba
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 6 deletions.
2 changes: 1 addition & 1 deletion modules/docs/lib/widgetUtils.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,7 @@ export const SymbolDoc = ({
const symbolDocContents = (
<StyledSymbolDoc {...elemProps}>
<HeadingLevelContext.Provider value={headingStart}>
{!hideHeading && <Heading>{name}</Heading>}
{!hideHeading && <Heading id={name}>{name}</Heading>}
{!hideDescription && doc && (
<MdxJSToJSX>{descriptionOverride || doc.description}</MdxJSToJSX>
)}
Expand Down
4 changes: 3 additions & 1 deletion modules/docs/lib/widgets/component.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@ import {Heading} from '../widgetUtils';
registerWidget<ComponentValue>('component', ({value, doc, meta}) => {
return (
<>
<Heading headingOffset={1}>Props</Heading>
<Heading id={`${value.displayName?.toLocaleLowerCase()}-props`} headingOffset={1}>
Props
</Heading>
<PropertiesTable properties={value.props}></PropertiesTable>
</>
);
Expand Down
19 changes: 15 additions & 4 deletions modules/docs/lib/widgets/enhancedComponent.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,12 @@ registerWidget<EnhancedComponentValue>('enhancedComponent', ({value, doc, meta})
<>
{value.styleComponent ? (
<>
<Heading headingOffset={1}>Layout Component</Heading>
<Heading
headingOffset={1}
id={`${value.displayName?.toLocaleLowerCase()}-layout-component`}
>
Layout Component
</Heading>
<MDX as="p">
<code>{value.displayName || parentComponentName}</code> supports all props from the
<code>
Expand All @@ -80,7 +85,9 @@ registerWidget<EnhancedComponentValue>('enhancedComponent', ({value, doc, meta})
</MDX>
</>
) : null}
<Heading headingOffset={1}>Props</Heading>
<Heading headingOffset={1} id={`${value.displayName?.toLocaleLowerCase()}-props`}>
Props
</Heading>
{value.baseElement && (
<ParentComponentJSDocContext.Provider value={defaultJSDoc}>
<MDX as="p">
Expand Down Expand Up @@ -122,7 +129,9 @@ registerWidget<EnhancedComponentValue>('enhancedComponent', ({value, doc, meta})
? value.subComponents.map((c, i) => {
return (
<React.Fragment key={i}>
<Heading>
<Heading
id={`${value.displayName?.toLocaleLowerCase()}-${c.name.toLocaleLowerCase}`}
>
{parentComponentName ? parentComponentName : value.displayName}.{c.name}
</Heading>
<ParentComponentNameContext.Provider
Expand All @@ -145,7 +154,9 @@ registerWidget<EnhancedComponentValue>('enhancedComponent', ({value, doc, meta})
: null}
{value.componentType === 'container' && value.model ? (
<>
<Heading headingOffset={-1}>Model</Heading>
<Heading id={`${value.displayName?.toLocaleLowerCase()}-model`} headingOffset={-1}>
Model
</Heading>
<SymbolDoc name={`use${value.model}`} />
</>
) : null}
Expand Down

0 comments on commit 8e810ba

Please sign in to comment.