Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial code owners configuration #460

Open
wants to merge 6 commits into
base: trunk
Choose a base branch
from
Open

Conversation

swissspidy
Copy link
Member

Moving checks into separate folders per category makes it easy to set up code owners.

Feel free to submit suggestions to the CODEOWNERS file if you like to be included/excluded.

See #448

@swissspidy swissspidy added the Infrastructure Issues for the overall plugin infrastructure label Apr 29, 2024
@swissspidy swissspidy added this to the 1.1.0 milestone Apr 29, 2024
Copy link
Member

@joemcgill joemcgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a great idea. To make management easier, we could consider assigning teams like @WordPress/performance-admins to the Performance section. Not sure if other community teams have similar groups that could be used.

Some practical questions/concerns:

  1. This should include a changelog entry, since several namespaces are changing.
  2. There a chance that someone is already extending this plugin with their own custom checks. Do we need to be concerned about adding backcompat support for the previous names, or is adding documentation to the release notes enough?

@swissspidy
Copy link
Member Author

swissspidy commented Apr 29, 2024

We can create new teams for each category or something if we want, e.g. @WordPress/plugin-check-plugins-team, @WordPress/plugin-check-performance. Don't want to use that existing team though, as it includes too many people who aren't contributing this plugin and would just unnecessarily get pinged because of it (like right now :)).

(Edit: also keep in mind mentioning/assigning teams doesn't work for people not in the org or when logged out of GitHub)

Not worried about back compat, a changelog entry should be enough.

Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @swissspidy, for the PR. Overall, it looks good to me. I've left one nit-pick and a couple of questions:

readme.txt Show resolved Hide resolved
@swissspidy
Copy link
Member Author

Who is responsible for the other checks and other infrastructure-related files?

Everyone and no one :) Something we can define as we go. Suggestions welcome if you think we should define all of that already.

Copy link

github-actions bot commented Jul 3, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: swissspidy <[email protected]>
Co-authored-by: joemcgill <[email protected]>
Co-authored-by: westonruter <[email protected]>
Co-authored-by: mukeshpanchal27 <[email protected]>
Co-authored-by: adamsilverstein <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@adamsilverstein
Copy link
Member

Looks great and this will let individual teams iterate more rapidly. +1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Issues for the overall plugin infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants