-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial code owners configuration #460
base: trunk
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a great idea. To make management easier, we could consider assigning teams like @WordPress/performance-admins to the Performance section. Not sure if other community teams have similar groups that could be used.
Some practical questions/concerns:
- This should include a changelog entry, since several namespaces are changing.
- There a chance that someone is already extending this plugin with their own custom checks. Do we need to be concerned about adding backcompat support for the previous names, or is adding documentation to the release notes enough?
We can create new teams for each category or something if we want, e.g. (Edit: also keep in mind mentioning/assigning teams doesn't work for people not in the org or when logged out of GitHub) Not worried about back compat, a changelog entry should be enough. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @swissspidy, for the PR. Overall, it looks good to me. I've left one nit-pick and a couple of questions:
- Who is responsible for the other checks and other infrastructure-related files?
- The documentation at https://github.com/WordPress/plugin-check/tree/trunk/docs should be updated to reflect the new changes related to checks.
Everyone and no one :) Something we can define as we go. Suggestions welcome if you think we should define all of that already. |
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Looks great and this will let individual teams iterate more rapidly. +1. |
Moving checks into separate folders per category makes it easy to set up code owners.
Feel free to submit suggestions to the CODEOWNERS file if you like to be included/excluded.
See #448