Fix: Image block - Lightbox Button position

[Takshil-Kunadia]

What?

Fixes: #66958

Why?

The button's absolute positioning, determined by top and right values, is influenced by several factors. However, in some scenarios, the resulting position can be suboptimal.

For a standard Image block, the positioning generally works well. But when the Image block adopts a non-default layout, especially within nested containers, the positioning becomes inconsistent and erratic.

How?

This PR adds on to the logic of calculating the buttons's position relatively to the size of the image inside the figure tag and sets default minimum positions of the button.

Testing Instructions

1. Create a post and add a Group block and set to a Grid variant.
2. inside the group block add 6 images with varying sizes/ratio and with and without captions.
3. Publish and view the front end.
4. Hover on the images.
5. Observe the placement of the trigger button.

Testing Instructions for Keyboard

Screenshots or screencast

Screen.Recording.2024-11-15.at.10.08.25.PM.mov

[Takshil-Kunadia]

Although, this will take care of 99% of use cases. However, notice the last image. I was blocked as to how to handle the positioning in an extremely small image.

[github-actions]

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

• Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
• Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

[github-actions]

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

• Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
• Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Takshil-Kunadia <[email protected]>
Co-authored-by: michalczaplinski <[email protected]>
Co-authored-by: luisherranz <[email protected]>
Co-authored-by: afercia <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.