Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Block Supports: Try stabilizing common experimental block support flags #67018

Draft
wants to merge 2 commits into
base: update/stabilize-border-block-supports
Choose a base branch
from

Conversation

aaronrobertshaw
Copy link
Contributor

⚠️ ⚠️ This PR is incomplete and not ready for review⚠️ ⚠️

Depends on:

What?

Extends the approach to block support stabilization in #66918 to also stabilize shared/common experimental block support flags such as:

  • __experimentalSkipSerialization
  • __experimentalDefaultControls

Why?

These experimental flags have been around a long time and are extensively used throughout core blocks. It's time to stabilize them to increase confidence for extenders and better document what is possible.

How?

Next Steps

  • Update uses of __experimentalSkipSerialization and __experimentalDefaultControls within Gutenberg's block supports
  • Clean up and performance checks

Future follow-ups

  • Updating core blocks within block library to use the stabilized keys.

Testing Instructions

Warning: This is likely going to need considerable testing!

  1. Add a range of blocks to a post that use multiple types of block supports e.g. border, color, typography etc.
  2. Check that all styles for these blocks display correctly when adjusted
  3. Make sure that the block has appropriate controls available within Global Styles and the block inspector
  4. Modify the block.json config for all the blocks to use varying combinations of experimental and stable flags.
  5. Repeat steps 2 & 3 to ensure the newly modified config is reflected and styling continues to work as before
  6. Add a filter to your theme that filters the block type arg in different ways and repeat the earlier checks again
  7. Add multiple filters that would switch things up at each application of a filter.
  8. Confirm the end result of config stabilizations and merges are as expected.

Screenshots or screencast

There should be no visual differences in blocks between this PR and trunk. Any found are regressions.

@aaronrobertshaw aaronrobertshaw added [Type] Enhancement A suggestion for improvement. [Feature] Block API API that allows to express the block paradigm. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi labels Nov 15, 2024
@aaronrobertshaw aaronrobertshaw self-assigned this Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Block API API that allows to express the block paradigm. [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant