-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent cURL transport from leaking on Exception #319
Open
soulseekah
wants to merge
10
commits into
WordPress:develop
Choose a base branch
from
soulseekah:fix-curl-leak-exception
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Sep 11, 2023
-
Prevent cURL transport from leaking on Exception
The `CURLOPT_HEADERFUNCTION` and `CURLOPT_WRITEFUNCTION` options are not being reset if a cURL handle error occurs (which throws a `Requests_Exception` and stops execution). The destructor is not called due to lingering instance method callbacks in the two options. Move `CURLOPT_HEADERFUNCTION` and `CURLOPT_WRITEFUNCTION` cleanup before any exceptions can happen.
Configuration menu - View commit details
-
Copy full SHA for a039381 - Browse repository at this point
Copy the full SHA a039381View commit details -
Configuration menu - View commit details
-
Copy full SHA for 76be0b7 - Browse repository at this point
Copy the full SHA 76be0b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7a56b5c - Browse repository at this point
Copy the full SHA 7a56b5cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 846ea8f - Browse repository at this point
Copy the full SHA 846ea8fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4589dba - Browse repository at this point
Copy the full SHA 4589dbaView commit details -
Configuration menu - View commit details
-
Copy full SHA for e67a478 - Browse repository at this point
Copy the full SHA e67a478View commit details -
Configuration menu - View commit details
-
Copy full SHA for 30afc43 - Browse repository at this point
Copy the full SHA 30afc43View commit details -
Configuration menu - View commit details
-
Copy full SHA for dd91131 - Browse repository at this point
Copy the full SHA dd91131View commit details -
Configuration menu - View commit details
-
Copy full SHA for 61b3b14 - Browse repository at this point
Copy the full SHA 61b3b14View commit details -
Configuration menu - View commit details
-
Copy full SHA for e1cd380 - Browse repository at this point
Copy the full SHA e1cd380View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.