lcesave.hexpat: use Virtual Filesystem + ZLib support + auto endian detection #309
Conversation
| import std.mem; | ||
| import std.core; | ||
| import hex.dec; | ||
| #ifdef __IMHEX__ |
There was a problem hiding this comment.
Where does the __IMHEX__ define come from?
There was a problem hiding this comment.
It is defined internally before pattern is evaluated. All patterns have it. In the source code you will find it in content_registry.cpp line 612
runtime.addDefine("__IMHEX__");
runtime.addDefine("__IMHEX_VERSION__", ImHexApi::System::getImHexVersion());Patterns shouldn't test for it, that's done internally in includes\hex\impl\imhex_check.pat
There was a problem hiding this comment.
DexrnZacAttack, why are you testing for this define?
There was a problem hiding this comment.
It isn't my place to reply since you asked the author directly, but note that the commit that adds the test for the define has "ifdefs to fix actions moment " as comment, so I suspect that it has to do with unit tests which wouldn't define the IMHEX variable because tests don't use the runtime. Also it would make little sense to warn user during a test run which is supposed to run automatically.
There was a problem hiding this comment.
Thanks, Paxcut.
Just saw this thread, yes this is the case, as the actions stuff was failing without that check.
|
Thank you! |
No description provided.