Updated the custom themes to the new text editor color palettes #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ned for full syntax highlighting, but the existing themes should look just like they did before.
… view fix: pe pattern could read past the end of file if symbol search option was turned on and input file had no symbols. In that case a StringTable array that has 1 element would be created and place at offset 0 where the size variable was set to a large number creating the error. The fix is to set the size of the array using numberOfSymbols>0
…use even if findSymbols is not on the file can contain symbols. This was causing the pe unit test to fail. To get the right array size use sizeof(symbolTable)>0 which will be 1 only if findSymbols is true and the file actually contains symbols
|
This pull request should be easy to review but hasn't seen any comments for 3 months. I don't mean to be pushy and this is certainly not critical stuff but as the new policy for dealing with issues that are old has been put in effect and seems to be showing signs of improvement, I think it isn't a bad idea to implement a similar approach for PRs that can be considered to be stale. Asking to be reviewed every three months should be reasonable I think but if in disagreement by all means suggest a better time interval. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though the new palettes were designed for full syntax highlighting, the existing themes should look just like they did before. Full syntax highlights will need the use of new themes that are added in other repositories.