Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test: Attachment with symbols in filename #436

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions tests/issues/Issue410Test.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,14 @@
namespace Tests\issues;

use PHPUnit\Framework\TestCase;
use Tests\fixtures\FixtureTestCase;
use Webklex\PHPIMAP\ClientManager;
use Webklex\PHPIMAP\Message;

class Issue410Test extends TestCase {
class Issue410Test extends FixtureTestCase {

public function testIssueEmail() {
$filename = implode(DIRECTORY_SEPARATOR, [__DIR__, "..", "messages", "issue-410.eml"]);
$message = Message::fromFile($filename);
$message = $this->getFixture("issue-410.eml");

self::assertSame("☆第132号 「ガーデン&エクステリア」専門店のためのQ&Aサロン 【月刊エクステリア・ワーク】", (string)$message->subject);

Expand All @@ -34,8 +34,7 @@ public function testIssueEmail() {
}

public function testIssueEmailB() {
$filename = implode(DIRECTORY_SEPARATOR, [__DIR__, "..", "messages", "issue-410b.eml"]);
$message = Message::fromFile($filename);
$message = $this->getFixture("issue-410b.eml");

self::assertSame("386 - 400021804 - 19., Heiligenstädter Straße 80 - 0819306 - Anfrage Vergabevorschlag", (string)$message->subject);

Expand All @@ -49,4 +48,17 @@ public function testIssueEmailB() {
self::assertSame("2021_Mängelliste_0819306.xlsx", $attachment->name);
}

public function testIssueEmailSymbols() {
$message = $this->getFixture("issue-410symbols.eml");

$attachments = $message->getAttachments();

self::assertSame(1, $attachments->count());

$attachment = $attachments->first();
self::assertSame("Checkliste 10.,DAVIDGASSE 76-80;2;2.pdf", $attachment->description);
self::assertSame("Checkliste 10.,DAVIDGASSE 76-80;2;2.pdf", $attachment->filename);
self::assertSame("Checkliste 10.,DAVIDGASSE 76-80;2;2.pdf", $attachment->name);
}

}
22 changes: 22 additions & 0 deletions tests/messages/issue-410symbols.eml
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
From: [email protected]
To: [email protected]
Subject: =?iso-8859-1?Q?386_-_400021804_-_19.,_Heiligenst=E4dter_Stra=DFe_80_-_081?=
=?iso-8859-1?Q?9306_-_Anfrage_Vergabevorschlag?=
Date: Wed, 13 Sep 2017 13:05:45 +0200
MIME-Version: 1.0
Content-Type: multipart/mixed;
boundary="------------B832AF745285AEEC6D5AEE42"

Hi
--------------B832AF745285AEEC6D5AEE42
Content-Type: application/pdf; name="Checkliste 10.,DAVIDGASSE 76-80;2;2.pdf"
Content-Description: Checkliste 10.,DAVIDGASSE 76-80;2;2.pdf
Content-Disposition: attachment;
filename="Checkliste 10.,DAVIDGASSE 76-80;2;2.pdf"; size=3439313;
creation-date="Tue, 12 Sep 2023 06:53:03 GMT";
modification-date="Tue, 12 Sep 2023 08:18:16 GMT"
Content-ID: <[email protected]>
Content-Transfer-Encoding: base64

SGkh
--------------B832AF745285AEEC6D5AEE42--
Loading