Config file handling #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Config handling should be async only on load (or on refresh). For this I've made the following changes/additions: 1) The graph is not drawn on load - only when done loading the config file (or on failure). 2) The config is requested in the Factory's constructor - if request fails, asks for defaultConfig. 3) Added local method defaultConfig. 4) Added prototype method: getConfig 5) initLayout uses existing config (should explicitely use "refreshConfig" in order to change the 6) Added prototype method: "refreshConfig" which fetches config from the config file.
There was an error when accessing the Ajax response. Was trying to get config directly from "response" but should have been "response.data"
|
In the latest version, you can set config from the component, or if not setting any using a default config (eliminating the config file) Is there anything else in this PR still relevant? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Config handling should be async only on load (or on refresh). For this
I've made the following changes/additions:
file (or on failure).
fails, asks for defaultConfig.
"refreshConfig" in order to change the
config file.