Added shipping_method_checkout_name to create parcel #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
villermen
approved these changes
Aug 13, 2024
There was a problem hiding this comment.
Hey! Sorry for not getting back to this sooner. I wanted to take this PR as an opportunity to look into the amount of optional parameters to the createParcel() method. That should however be unrelated and for a future version (#38). Changes are good and I'm perfectly fine with them! Thanks for your contribution. I'll merge and push out a new version in a bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
shipping_method_checkout_name, which is a free field that can be set when creating a parcel. We use this field to send a custom value to Sendcloud which can then be used by shipping rules to make decisions on.This value can then be used in the shipment rules as following:
