Improve formating of spellId & time options #4550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stanzilla
approved these changes
Jul 26, 2023
mrbuds
force-pushed
the
ui
branch
2 times, most recently
from
4b7570f
to
5738f69
Compare
InfusOnWoW
requested changes
Jul 30, 2023
InfusOnWoW
reviewed
Jul 31, 2023
Merged
… icon & name of spell
InfusOnWoW
force-pushed
the
ui
branch
3 times, most recently
from
11bfe77
to
b22b51e
Compare
This use a modified version of LibDDI-Sound ace3 widget
change is 99% copy from subtext commit d4efcd9
Even those set via conditions. Also create all formatters on modify time, so that they are ready once the text changes
InfusOnWoW
approved these changes
Aug 19, 2023
| @@ -986,7 +992,11 @@ Private.event_prototypes["BigWigs Message"] = { | |||
| init = "arg", | |||
| display = L["Key"], | |||
| desc = L["The 'Key' value can be found in the BigWigs options of a specific spell"], | |||
| type = "longstring" | |||
There was a problem hiding this comment.
I guess the "contains" and "pattern matching" options were essentially useless, so changing this is okay for me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ##4549