Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul Solid implementations support #39

Merged
merged 2 commits into from
May 20, 2024
Merged

Conversation

WarningImHack3r
Copy link
Owner

@WarningImHack3r WarningImHack3r commented May 18, 2024

Both shadcn-solid and solid-ui have (greatly) diverged from the original shadcn/ui implementation since their initial support in this plugin.

Consequently, I have to make significant changes to make my code even more flexible to keep other framework implementations working and add support for those two.

Evolving list of divergences

Common

  • No longer support the style value in the config
  • No longer support the baseColor value in the config

Changes in shadcn-solid

  • Adds support for UnoCSS (Tailwind is now optional as a result)

Changes in solid-ui

  • Renames its config from components.json to ui.config.json
  • No longer supports aliases in the config except for a custom path one

@WarningImHack3r WarningImHack3r self-assigned this May 18, 2024
Copy link
Contributor

github-actions bot commented May 18, 2024

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true
Contact Qodana team

Contact us at [email protected]

- Modify code due to new configs
- Split both Solid sources
- Fix usage of cssVariables for Solid
- Add/fix JavaDocs for configs
- Add unsupported JS for React & Solid
- Add `~` for aliases prefixes
@WarningImHack3r WarningImHack3r marked this pull request as ready for review May 20, 2024 13:16
@WarningImHack3r WarningImHack3r merged commit 000c765 into main May 20, 2024
5 of 6 checks passed
@WarningImHack3r WarningImHack3r deleted the solid-updates branch May 20, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant