Rewrite the Tailwind classes replacement & imports replacement engines, update configs #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
SaltyHunter
approved these changes
May 6, 2024
src/test/kotlin/com/github/warningimhack3r/intellijshadcnplugin/DummyTests.kt
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
I know understand andOr
WarningImHack3r
force-pushed
the
ast-classes-parsing
branch
from
223e573 to
283acfd
Compare
WarningImHack3r
changed the title
- Fix r/w issues by moving actions - Create a visitor for React directives - Change way of working of current visitors for r/w - Fix format for test files - Fix code smell - Remove (now?) useless Source.cleanAlias
- Move `runXAction`s to the lower possible level - Fix their usage - Fix inverted condition for RSC in React - Invert condition in VueSource for readability - Remove useless createPsiFile(Project, FileType, String)
Now time for regressions and stuff (I wish there was a better solution than allowSlowOperations {} though)
- Fix another read action issue - Fix cssVariables setting never used for React - Fix cssVariables being misused for Vue - Fix imports replacements for Svelte
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/[email protected]
with:
upload-result: trueContact Qodana teamContact us at [email protected]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the regex-based Tailwind classes replacement mechanism with an AST-based one. It will help better support various cases not working with the current implementation, as well as reduce the code verbosity.
The AST parsing requires the built-in
JavaScriptmodule, which is only available on WebStorm and IntelliJ IDEA Ultimate. Other IDEs are thus no longer supported.Also, the Svelte and Vue extensions (JSX support is built-in/sufficient with the
JavaScriptmodule), mandatory to be able to parse their associated files, are also now dependencies of this plugin.Vue is already a built-in plugin for IU & WS, however Svelte will have (unless I find a workaround) to be installed with this plugin.However, both plugins are optional to install.A similar engine is also brought to the imports replacement part, as well as for React's
"use X"directives. Frameworks configurations have also been updated for comprehensive implementations.TODO list