Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support php_only subset #148

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Support php_only subset #148

merged 2 commits into from
Feb 9, 2024

Conversation

przepompownia
Copy link
Contributor

No description provided.

@Wansmer
Copy link
Owner

Wansmer commented Feb 9, 2024

Thanks for the PR!
Please add php_only to the languages section of README.md and create test files like for regular php.

More about tests here.

@przepompownia
Copy link
Contributor Author

Looks like copy-paste (because of the same parser). What do you propose to avoid duplication?

Thanks for the PR! Please add php_only to the languages section of README.md and create test files like for regular php.

@Wansmer
Copy link
Owner

Wansmer commented Feb 9, 2024

Looks like copy-paste (because of the same parser). What do you propose to avoid duplication?

If it's just a copy and paste, you don't need to.
Does php_only and php have the same file extension?
If so, let me know and I'll merge the PR.

@przepompownia
Copy link
Contributor Author

If I understand correctly, php_only does not include injections for HTML - look at the queries in nvim-treesitter.

@przepompownia
Copy link
Contributor Author

przepompownia commented Feb 9, 2024

Yes, both are for php although I need to call

vim.treesitter.language.register('php_only', {'php'})

from my configs.

@Wansmer Wansmer merged commit fc8f18b into Wansmer:main Feb 9, 2024
2 checks passed
@przepompownia
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants