Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dot repetition for presets #147

Merged
merged 4 commits into from
Feb 7, 2024

Conversation

backdround
Copy link
Contributor

Dot repetition for format functions with presets didn't work.

I think it was a bug, though I didn't take a thought about it

@backdround
Copy link
Contributor Author

backdround commented Feb 7, 2024

Does someone use the dot_repeat = false flag?

I mean, it's kind of expected to enable dot-repetition by default. I'm not sure if it's needed, but I wouldn't insist on removing it

@Wansmer
Copy link
Owner

Wansmer commented Feb 7, 2024

These are nice improvements, but I think you should mark mode_to_use and preset_to_use as private fields (with __ at the start) since this is not a public API.

Does someone use the dot_repeat = false flag?

I mean, it's kind of expected to enable dot-repetition by default. I'm not sure if it's needed, but I wouldn't insist on removing it

"dot_repeat = false" language:Lua in a github search shows that some users are using it.

@backdround
Copy link
Contributor Author

Updated

@Wansmer
Copy link
Owner

Wansmer commented Feb 7, 2024

Thanks for contributions!

@Wansmer Wansmer merged commit 59ec170 into Wansmer:main Feb 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants