Fixes to upstream #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced `with_items:` loop construct with `loop:`.
wpa_supplicant by default enables WiFi Direct functionality. In case you have no need for this functionality you can disable it by defining `wpa_p2p_disabled: 1`. Having P2P enabled adds a socket file to the control path (default at `/var/run/wpa_supplicant`). Calls to `wpa_cli reconfigure` can end up trying to reconfigure the `p2p-dev-wlan0` instead of `wlan0`. Disabling P2P functionality prevents generation of the `p2p-dev-wlan0` socket file and restore expected `wpa_cli reconfigure` behaviour.
When Ansible was run in check mode the task to generate the encrypted passphrase would not be executed causing the variable substitution in them template following to fail. Now we always run the `wpa_passphrase` command, even in check mode.
Ansible 2.7 handles looping with package managers differently. [1] It used to perform list squashing when the loop detected it was being combined with a package manager module that supported installing the packages in a single transaction. Because this is no longer the case it's better to give a list of packages to the package manager module. [1]: https://docs.ansible.com/ansible/devel/porting_guides/porting_guide_2.7.html#using-a-loop-on-a-package-module-via-squash-actions
|
Also: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I performed some maintenance and made some improvements to your nice Ansible wpa_supplicant role.
Perhaps they are of interest of you?
The commits should speak for themselves on what they change.
I would of course be happy to answer any questions, ideas or objections you might have.