Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(providers): Near chain ID to be CAIP-2 compatible #547

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

geekbrother
Copy link
Contributor

Description

This PR changes the chain Id for the Near to be CAIP-2 compatible and becomes near:mainnet instead of near.
According to the Grafana chain Ids requests, at the moment we don't have any Near traffic yet (we've added it recently), so we can switch it without migration.

How Has This Been Tested?

Integration tests.

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@geekbrother geekbrother self-assigned this Mar 1, 2024
@geekbrother geekbrother changed the title fix(providers): Near chain id to be CAIP-2 compatible fix(providers): Near chain ID to be CAIP-2 compatible Mar 1, 2024
@geekbrother geekbrother force-pushed the fix/change_near_to_near_mainnet branch from e664002 to a37a275 Compare March 1, 2024 16:00
@geekbrother geekbrother marked this pull request as ready for review March 1, 2024 16:00
@geekbrother geekbrother force-pushed the fix/change_near_to_near_mainnet branch from a37a275 to 0177f20 Compare March 1, 2024 16:11
Copy link
Member

@chris13524 chris13524 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically there should be a CAIP-2 entry in ChainAgnostic/namespaces but I see an abandoned PR which matches what you've done here so approving 👍

Opening this issue for standardizing this: ChainAgnostic/namespaces#106

@geekbrother geekbrother merged commit b96bec0 into master Mar 1, 2024
12 checks passed
@geekbrother geekbrother deleted the fix/change_near_to_near_mainnet branch March 1, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants