Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link Mode #312

Merged
merged 25 commits into from
Sep 3, 2024
Merged

Link Mode #312

merged 25 commits into from
Sep 3, 2024

Conversation

quetool
Copy link
Collaborator

@quetool quetool commented Aug 20, 2024

Description

  • Link Mode implementation
  • Added a handy method to redirect back to or open Wallet/Dapp
    • redirectToWallet() for Dapps
    • redirectToDapp() for Wallets
  • Additionally openURL() method was added in WalletConnectUtils
  • Change Connectivity into a notifier so developer can use it rather than just use it internally in the SDK
  • Fix a bug where nonce in Transaction was treated as integer

How Has This Been Tested?

  • Extensive manual tests
  • Smoke tests
  • Unit Tests where needed
Android iOS

Due Dilligence

  • Breaking change
  • Requires a documentation update

@quetool quetool changed the title Minor changes Link Mode Aug 23, 2024
@quetool quetool marked this pull request as ready for review August 26, 2024 14:19
Copy link

sonarcloud bot commented Sep 3, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
64.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@quetool quetool merged commit ec04b4e into develop Sep 3, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants