Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/one click auth support #295

Merged
merged 35 commits into from
Jun 28, 2024
Merged

Feature/one click auth support #295

merged 35 commits into from
Jun 28, 2024

Conversation

quetool
Copy link
Collaborator

@quetool quetool commented Jun 11, 2024 •
edited
Loading

Description

  • One-Click Auth support both for dApps and Wallets
  • Exposed a log listener on Core for host app's to listen
  • Added reject and autoReject tags for WC_SESSION_PROPOSE method
  • Fixed an issue where rejections were not handled with the proper rpc options https://walletconnect.slack.com/archives/C04DB2EAHE3/p1718276708492719
  • Fixed an issue where pairing uri and pairing info were being created with a List of List for methods parameter and expiry was missing
  • Added methods value to PairingInfo as other SDKs does.

How Has This Been Tested?

  • Unit tests and manual tests
demo.mov

Due Dilligence

  • Breaking change
  • Requires a documentation update

quetool and others added 30 commits May 20, 2024 12:10
@quetool
remove signclient and auth client and minor preparations
025a0d0
@quetool
preparation for future mixpanel events
7f95148
@quetool
Merge branch 'master' of https://github.com/WalletConnect/WalletConne…
6fc2c89 
…ctFlutterV2 into feature/1_click_auth
@quetool
moved auth api method inside sign api
db1f9d1
@quetool
Merge branch 'master' of https://github.com/WalletConnect/WalletConne…
e48e766 
…ctFlutterV2 into feature/1_click_auth
@quetool
revert some files
4facb2b
@quetool
revert some files
dbda6c7
@quetool
revert some files
816364b
@quetool
final changes on setup
e7fedb1
@quetool
Implemented all the necessary to support 1CA from dapp side (no fallb…
6b649f8 
…ack to session proposal yet)
@quetool
fixed tests
8f9772f
@quetool
minor changes
d5aa1f6
@quetool
minor changes
35c7989
@quetool
Merge pull request #292 from WalletConnect/feature/1_click_auth
461f1aa 
Feature/1 click auth
@quetool
fallback method implemeted
19d6f80
@quetool
minor change
d27f923
@quetool
Merge pull request #294 from WalletConnect/chore/one_click_auth_fallb…
513ebc1 
…ack_mecanism

Chore/one click auth fallback mecanism
@quetool
minor change and version upgrade
ad938e7
@quetool
some file renaming and moving
291381d
@quetool
renabled authegine for backward compatibility
2dec71b
@quetool
minor changes
397b769
@quetool
Merge pull request #296 from WalletConnect/chore/restablish_auth_engine
c24277d 
Reestablish usability of AuthEngine for backward compatibility
@quetool
minor changes
c6084e6
@quetool
wallet side implementation an bug fixes
59620c2
@quetool
minor changes
78d98db
@quetool
Delete unused generated files
55478f6
@quetool
minor changes
f0d0013
@quetool
minor changes and fixed tests
08d8997
@quetool
Merge pull request #297 from WalletConnect/chores/one_click_auth_wall…
f84d287 
…et_side_implementation

Wallet side implementation an bug fixes
@quetool
minor change
b36e4e5
@quetool quetool marked this pull request as ready for review June 25, 2024 11:12
@quetool quetool self-assigned this Jun 25, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@quetool quetool merged commit 3372606 into master Jun 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubuid jakubuid Awaiting requested review from jakubuid

@llbartekll llbartekll Awaiting requested review from llbartekll

@ignaciosantise ignaciosantise Awaiting requested review from ignaciosantise

@ganchoradkov ganchoradkov Awaiting requested review from ganchoradkov

Assignees

@quetool quetool

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@quetool