Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/1 click auth #292

Merged
merged 13 commits into from
Jun 10, 2024
Merged

Conversation

quetool
Copy link
Collaborator

@quetool quetool commented May 23, 2024

Description

First iteration on support One-Click Auth:

  • Moved AuthEngine logic to SignEngine (commented files will be deleted when the whole task is done)
  • Implemented OCA methods to support Dapp's side (Wallet is coming next) that can be leveraged by Web3Modal SDK

Still to be done:

  • Fallback to session proposal mechanism
  • Wallet support of OCA

How Has This Been Tested?

  • A lot of manual testing with different wallets that supports OCA. (Trust Wallet, Zerion, WC Swift Sample Wallet, WC Kotlin Sample Wallet, WC React-Wallet)

  • Will add integration test when the task is completed

Due Dilligence

  • Breaking change
  • Requires a documentation update

@quetool quetool self-assigned this May 24, 2024
@quetool quetool added the enhancement New feature or request label May 24, 2024
@quetool quetool changed the base branch from master to feature/one_click_auth_support June 6, 2024 16:54
Copy link

sonarcloud bot commented Jun 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@quetool quetool marked this pull request as ready for review June 7, 2024 09:46
@quetool quetool merged commit 461f1aa into feature/one_click_auth_support Jun 10, 2024
1 check passed
@quetool quetool deleted the feature/1_click_auth branch June 28, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant