Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Redirect validation during Web3Wallet and Web3App initialization #277

Closed
wants to merge 3 commits into from

Conversation

quetool
Copy link
Collaborator

@quetool quetool commented Mar 8, 2024

Description

Added Redirect validation during Web3Wallet and Web3App initialization

Possible errors that the wallet or dapp developer would see in the console log if something wrong is happening with the Redirect value:

  1. CFBundleURLTypes key is missing from Info.plist (screenshot is wrong by saying CFBundleURLSchemes, it was already changed to CFBundleURLTypes)
    1

  2. The whole Redirect object is missing from PairingMetada
    2

  3. Only native option from Redirect object is missing
    3

  4. native option on Redirect object is set but not included in CFBundleURLTypes key
    4

Example for Web3Wallet are given but the same will happen for Web3App

Due Dilligence

  • Breaking change
  • Requires a documentation update

@quetool quetool self-assigned this Mar 8, 2024
@quetool quetool added the wip label Mar 11, 2024
Copy link

sonarcloud bot commented Mar 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@quetool quetool closed this Mar 14, 2024
@quetool quetool deleted the feature/metadata_redirect_validation branch April 2, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant