You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows full access to SignEngine.approveSession (specifically sessionProperties) params from interfaces.
dApp and wallet are able to send optional sessionProperties via Proposal and Settlement messages according to spec. Currently the dApp client exposes this via connect() but wallet client does not in approveSession even though SignEngine.approveSession in fact does implement it. Though the interface (ISignEngineWallet) does not expose it.
I compared this to the JS sign client and it also exposes it here
Hello @hmendez-figure, thanks for opening! I'll check this PR as soon as I can, in the meantime could you add in the description and explanation on why is this needed? Thanks!
Hi @quetool, was there anything else needed or any concerns holding up this pull request? Our organization has taken to forking the repo to solve the problem about not having access to sessionProperties but would ideally like to revert and stay on the main branch/repo if possible. Thanks!
Never mind! I will just merge it and take care of it on my end! Thanks @hmendez-figure@VigM-Figure for this and sorry for the huge delay! It will be deployed on the next release! 👌
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allows full access to
SignEngine.approveSession(specificallysessionProperties) params from interfaces.dApp and wallet are able to send optional
sessionPropertiesvia Proposal and Settlement messages according to spec. Currently the dApp client exposes this viaconnect()but wallet client does not inapproveSessioneven thoughSignEngine.approveSessionin fact does implement it. Though the interface (ISignEngineWallet) does not expose it.I compared this to the JS sign client and it also exposes it here
Resolves # (issue)
How Has This Been Tested?
Smoke Test
Due Dilligence