Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exception happening during transaction parsing #265

Merged
merged 2 commits into from
Feb 12, 2024
Merged

Fix exception happening during transaction parsing #265

merged 2 commits into from
Feb 12, 2024

Conversation

quetool
Copy link
Collaborator

@quetool quetool commented Feb 10, 2024

Description

  • Fixed a parsing exception happening during sign/send Transaction.
  • Handling signTypedData and signTypedDataV4 separately

How Has This Been Tested?

  • Smoke and manual tests on different chains have been done

Due Dilligence

  • Breaking change
  • Requires a documentation update

@quetool quetool self-assigned this Feb 10, 2024
arein
arein approved these changes Feb 10, 2024
View reviewed changes
Copy link
Member

@arein arein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - bonus points for a regression test :)

@quetool quetool merged commit b155351 into master Feb 12, 2024
1 check passed
@quetool quetool deleted the bugfix/exception_during_transaction_parsing branch April 2, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arein arein arein approved these changes

Assignees

@quetool quetool

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@quetool @arein