Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Log Level without the need to import package logger as transitive dependency #184

Merged
merged 4 commits into from
Oct 16, 2023

Conversation

quetool
Copy link
Collaborator

@quetool quetool commented Sep 5, 2023

Description

Before PR: If developer wanted to use logLevel: parameter from Web3App and Web3Wallet instances used in Core module they had to import transitive dependency import 'package:logger/logger.dart'; which is redundant.

Screenshot 2023-09-05 at 12 49 54

Screenshot 2023-09-05 at 12 50 38

After PR: Developer will be able to use logLevel: parameter with a new enum value called LogLevel exported from apis/utils/log_level.dart. No need to import any dependency, just use logLevel: LogLevel.info

Resolves # (issue)

How Has This Been Tested?

No tests needed as this doesn't involve any change in behaviors.

Due Dilligence

  • Breaking change
  • Requires a documentation update

@quetool quetool self-assigned this Sep 5, 2023
@quetool quetool added the enhancement New feature or request label Sep 5, 2023
@quetool quetool merged commit b52c057 into master Oct 16, 2023
1 check passed
@quetool quetool deleted the feature/expose_log_level branch November 2, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants